Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul XP Bar system; adds right click menu & new logic #60

Merged
merged 13 commits into from
Dec 30, 2020

Conversation

Hubcapp
Copy link
Member

@Hubcapp Hubcapp commented Dec 12, 2020

New features:

  • Ability to pin XP bar permanently on screen (persists over client loads)
  • Ability to pin specific skill permanently (persists over client loads)
  • Ability to set arbitrary XP goals per skill (persists over client loads)
  • Recognition of separate user accounts (all features are per account, other than whether or not UI is pinned & which skill)
  • Ability to reset when the beginning of an XP gaining session is, for the purpose of more accurate XP/hr
  • Right click menu to control new XP bar features

Bug fixes:

  • Actions to Level seemed to be broken, now it is not
  • No longer get massive XP drops when first logging in
  • Switching accounts no longer gives massive XP drops
  • XP/hr tracking no longer resets after 3 minutes of skill inactivity
  • XP Drops now occur even if an interface is open (no more grouping up of XP drops)
  • Fixed bug consuming mousepress while in replay playback mode & player controls not shown but player bar is shown

Possible improvements:

  • Ability to change XP progress bar between Level & Goal mode (currently stuck in Level mode, but could add another right-click menu option for this)
  • Ability to change colour of XP progress bar to user's favourite colour, or depending on percent progress
  • Could offer per-account preferred skill pin
  • Could maybe space the right-click menu out a bit more
  • Maybe if an XP Level goal ends up being a round Level (e.g. 70.0), it should just say 70 instead of 70.0
  • Indicate how long the session has elapsed
  • Option to permanently stick the hover-menu somewhere on screen (top right corner while interfaces are closed?)
  • Make sure not to reset entire XP session on log out
  • Hours/Minutes to next level / goal
  • play Level Advance sound if reaching goal & goal level is not already on a level boundary
  • Can also put green message "Congratulations, you reached xxxxx XP!"

@Hubcapp Hubcapp requested a review from lmsv-mx123 December 12, 2020 00:05
@Hubcapp
Copy link
Member Author

Hubcapp commented Dec 12, 2020

Here's a precompiled jar if any non-developers would like to test this.
rscplus.zip

Copy link
Member Author

@Hubcapp Hubcapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been using this for about a week, it seems stable to me. Still would maybe like feedback from others.

src/Game/Client.java Outdated Show resolved Hide resolved
src/Game/AccountManagement.java Outdated Show resolved Hide resolved
@Hubcapp
Copy link
Member Author

Hubcapp commented Dec 30, 2020

  • must verify that this works with new accounts on tutorial island (before they get their first XP update)
  • should ensure that XP drops are still possible in replays.

@Hubcapp
Copy link
Member Author

Hubcapp commented Dec 30, 2020

seems to be compatible with creating new accounts as well.

@Hubcapp Hubcapp merged commit 9bbe3b6 into RSCPlus:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants