Skip to content

Commit

Permalink
fix: empty title break
Browse files Browse the repository at this point in the history
  • Loading branch information
DIYgod committed Sep 22, 2024
1 parent 92dff50 commit fbbb2a9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion apps/renderer/src/components/feed-icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ export function FeedIcon({
}

const colors = useMemo(
() => getColorScheme(stringToHue(feed?.title || (feed as FeedModel)?.url || siteUrl!), true),
() =>
getColorScheme(stringToHue(feed?.title || (feed as FeedModel)?.url || siteUrl || ""), true),
[feed?.title, (feed as FeedModel)?.url, siteUrl],

Check warning on line 103 in apps/renderer/src/components/feed-icon.tsx

View workflow job for this annotation

GitHub Actions / Format, Lint and Typecheck (18.x)

React Hook useMemo has a missing dependency: 'feed'. Either include it or remove the dependency array

Check warning on line 103 in apps/renderer/src/components/feed-icon.tsx

View workflow job for this annotation

GitHub Actions / Format, Lint and Typecheck (18.x)

React Hook useMemo has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked

Check warning on line 103 in apps/renderer/src/components/feed-icon.tsx

View workflow job for this annotation

GitHub Actions / Format, Lint and Typecheck (18.x)

React Hook useMemo has a missing dependency: 'feed'. Either include it or remove the dependency array

Check warning on line 103 in apps/renderer/src/components/feed-icon.tsx

View workflow job for this annotation

GitHub Actions / Format, Lint and Typecheck (18.x)

React Hook useMemo has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked
)
let ImageElement: ReactNode
Expand Down

0 comments on commit fbbb2a9

Please sign in to comment.