Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracker): make websocket optional #676

Merged
merged 1 commit into from
Apr 25, 2023
Merged

feat(tracker): make websocket optional #676

merged 1 commit into from
Apr 25, 2023

Conversation

Hoishin
Copy link
Member

@Hoishin Hoishin commented Apr 25, 2023 •
edited by pasta04
Loading

  • 寄付の無いイベントではdonationのwebsocketに接続する必要が無い
  • イベント期間外等でElasticCacheを止めてるとWebSocketのコネクションエラーが出続けるため、イベント期間外に開発する時に鬱陶しい
  • tracker.websocketをoptionalにして、未設定の時は繋がないようにした

@Hoishin Hoishin merged commit 3c221fd into master Apr 25, 2023
@Hoishin Hoishin deleted the ws-optinal branch April 25, 2023 17:49
@pasta04 pasta04 mentioned this pull request Apr 26, 2023
Closed
@pasta04 pasta04 added the extensions extensionsに影響する内容 label Apr 26, 2023
Hoishin added a commit that referenced this pull request Apr 27, 2023
@Hoishin
Merge branch 'master' into refactor/fit-text
21c8ff2 
* master:
  走者カメラをデフォルトでONにする (#678)
  寄付有無を設定可能にした (#679)
  feat(tracker): make websocket optional (#676)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extensions extensionsに影響する内容
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoishin @pasta04