Skip to content

Commit

Permalink
Removed the reference to the klayout ".map" file in the sky130
Browse files Browse the repository at this point in the history 
Makefile, because the file no longer exists in the repository.
  • Loading branch information
@RTimothyEdwards
RTimothyEdwards committed Mar 3, 2023
1 parent b5b53f8 commit 1683283
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion VERSION
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.397
1.0.398
1 change: 0 additions & 1 deletion sky130/Makefile.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,6 @@ klayout-%: ${KLAYOUT_PATH}
cp -rp ${KLAYOUT_PATH}/sky130_tech/tech/sky130/pymacros/* ${KLAYOUT_STAGING_$*}/pymacros/ ; \
cp ${KLAYOUT_PATH}/sky130_tech/tech/sky130/${TECH}.lyp ${KLAYOUT_STAGING_$*}/tech/${SKY130$*}.lyp ; \
cp ${KLAYOUT_PATH}/sky130_tech/tech/sky130/${TECH}.lyt ${KLAYOUT_STAGING_$*}/tech/${SKY130$*}.lyt ; \
cp ${KLAYOUT_PATH}/sky130_tech/tech/sky130/${TECH}.map ${KLAYOUT_STAGING_$*}/tech/${SKY130$*}.map ; \

This comment has been minimized.

Sign in to view

Copy link
@proppy

proppy Mar 7, 2023 •
edited

Contributor

I still see it here:
https://github.com/efabless/sky130_klayout_pdk/blob/main/sky130_tech/tech/sky130/sky130.map
and it looks like it's still in use in OpenLane here:
https://github.com/The-OpenROAD-Project/OpenLane/blob/ce916510de89a037889e06ab16c00c4101f77d2f/scripts/tcl_commands/klayout.tcl#L39
thru KLAYOUT_DEF_LAYER_MAP defined here:
https://github.com/RTimothyEdwards/open_pdks/blob/master/sky130/openlane/config.tcl#L96

This comment has been minimized.

Sign in to view

Copy link
@RTimothyEdwards

RTimothyEdwards Mar 7, 2023

Author Owner

The Makefile is currently pointed to the mabrains version of sky130_klayout_pdk. Please work out with Amro Tork who is actually responsible for the klayout decks for sky130 and how they will be tested to make sure that they don't break openlane.

This comment has been minimized.

Sign in to view

Copy link
@proppy

proppy Mar 7, 2023

Contributor

I see the efabless url being referenced here: https://github.com/RTimothyEdwards/open_pdks/blob/master/sky130/Makefile.in#L247 is that overriden somewhere else?

This comment has been minimized.

Sign in to view

Copy link
@RTimothyEdwards

RTimothyEdwards Mar 7, 2023

Author Owner

Okay, my fault. There is a slight issue with "make update" that it assumes repositories came from the same place as originally specified. If the URL for the repo changes, then "make update" just updates the existing repo, but won't notice that the repo has changed. So my own repo is still pointing to the mabrains version even though I changed it in the Makefile. So I will correct my own repo and revert this update. Thanks for the heads-up.
fi
# Copy original DRC deck from open_pdks (is this useful?)
cp klayout/sky130.lydrc ${KLAYOUT_STAGING_$*}/drc/${SKY130$*}.lydrc
Expand Down

0 comments on commit 1683283

Please sign in to comment.