Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fix the neg_sampling config #1215

Merged
merged 2 commits into from
Mar 29, 2022
Merged

FIX: fix the neg_sampling config #1215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eabb09
Update configurator.py
2017pxy Mar 29, 2022
cab979e
FIX: fix the bug in neg_sampling config
2017pxy Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recbole/config/configurator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def _init_device(self):

def _set_train_neg_sample_args(self):
neg_sampling = self.final_config_dict['neg_sampling']
if neg_sampling is None:
if neg_sampling is None or neg_sampling == 'None':
self.final_config_dict['train_neg_sample_args'] = {'strategy': 'none'}
else:
if not isinstance(neg_sampling, dict):
Expand Down