FIX: fix UserWarning in get_norm_adj_mat and accelerate csr2tensor #1225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running LightGCN, NGCF and NCL, there will be a UserWarning as follows:
The reason is that in
get_norm_adj_mat
, the type ofL.row
andL.col
isnumpy.ndarray
, soi =torch.LongTensor(np.array([row, col]))
creates a tensor from a list of numpy.ndarrays.RecBole/recbole/model/general_recommender/lightgcn.py
Lines 99 to 103 in 4f76169
In SGL,
numpy.ndarray
is converted tolist
by.tolist()
to avoid the warning.RecBole/recbole/model/general_recommender/sgl.py
Lines 158 to 161 in 4f76169
I test the running time of three methods on ml-1m, and converting the list to a single
numpy.ndarray
withnumpy.array()
before converting to a tensor is the quickest.