Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA: add show_progress to xgboostTrainer (have no effect) #644

Merged
merged 1 commit into from
Jan 2, 2021
Merged

FEA: add show_progress to xgboostTrainer (have no effect) #644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions recbole/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ def _valid_epoch(self, valid_data):
valid_score = calculate_valid_score(valid_result, self.valid_metric)
return valid_result, valid_score

def fit(self, train_data, valid_data=None, verbose=True, saved=True):
def fit(self, train_data, valid_data=None, verbose=True, saved=True, show_progress=False):
# load model
if self.xgb_model is not None:
self.model.load_model(self.xgb_model)
Expand Down Expand Up @@ -748,7 +748,7 @@ def fit(self, train_data, valid_data=None, verbose=True, saved=True):

return self.best_valid_score, self.best_valid_result

def evaluate(self, eval_data, load_best_model=True, model_file=None):
def evaluate(self, eval_data, load_best_model=True, model_file=None, show_progress=False):
self.eval_pred = torch.Tensor()
self.eval_true = torch.Tensor()

Expand Down