Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Sequential Dataset & DataLoader #873

Merged
merged 13 commits into from
Jul 10, 2021
Merged

Conversation

hyp1231
Copy link
Member

@hyp1231 hyp1231 commented Jul 9, 2021

No description provided.

@hyp1231 hyp1231 requested review from chenyushuo, 2017pxy and guijiql July 9, 2021 06:16
if field != self.uid_field and field + list_suffix in l1_inter_dict:
candidate_field_set.add(field)
new_dict[field] = torch.cat([self.inter_feat[field], l1_inter_dict[field + list_suffix][:,0]])
elif (not field.endswith(list_suffix)) and (field != self.item_list_length_field):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能满足这个条件的只有uid field吧

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

或许 target item 的其他 feature 也可以满足?

@@ -43,6 +43,7 @@ normalize_field: ~
normalize_all: ~

# Sequential Model Needed
augmentation: False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以这个参数还要保留吗?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

@2017pxy 2017pxy merged commit 36bffcf into RUCAIBox:data Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants