Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Tls13 support by requiring Windows .NET Framework 4.8 or higher #102

Closed
ddemeyer opened this issue Oct 5, 2020 · 0 comments
Closed
Milestone

Comments

@ddemeyer
Copy link
Contributor

ddemeyer commented Oct 5, 2020

Problem Statement
Currently the HTTPS handshake is limited to
ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12. Adding SecurityProtocolType.Tls13 requires to raise platform support from .NET Framework 4.5 and up to .NET Framework 4.8 (and up).

See framework versions on https://docs.microsoft.com/en-us/dotnet/api/system.net.securityprotocoltype?view=netframework-4.8

Solution

  • Raise the major version of the module, as this is a breaking change. And raise .NET Framework to 4.8 and extend the flags in ServicePointManagerHelper.cs.
  • Leave as-is, postpone the change and look into the future for an OpenAPI-based but also .NET Core 3.1+ based alternative which is also a breaking change.
@ddemeyer ddemeyer added this to the v1.0 milestone Oct 5, 2020
@ddemeyer ddemeyer modified the milestones: v1.0, V7.0 Sep 16, 2021
ddemeyer pushed a commit that referenced this issue Sep 16, 2021
…slPolicyErrors overwrite by switching to ChannelFactor instead of SoapClient. Crosslinking #102 on Tls13 and #22 as IshSession control Ssl-overwrite instead of AppDomain
ddemeyer pushed a commit that referenced this issue Aug 9, 2022
… Integration limited to net48 only though, so latest .NET Framework and Windows PowerShell. Delayed signing is removed from public ISHRemote project as described in #80 Using https://github.com/red-gate/XmlDoc2CmdletDoc as module (not as executable. All this, hat tip to Ivo!
ddemeyer pushed a commit that referenced this issue Aug 9, 2022
…ause branch release/v1 is a Windows PowerShell 5.1 and .NET Framework 4.8 only we can Close #102
@ddemeyer ddemeyer closed this as completed Aug 9, 2022
ddemeyer pushed a commit that referenced this issue Aug 9, 2022
…o 5.1.1 and several ServiceModel-related packages from 4.7.0 to 4.9.0
ddemeyer pushed a commit that referenced this issue Aug 11, 2022
ddemeyer added a commit that referenced this issue Aug 12, 2022
* #102 Branch unreleased v0.15 to v1. Switched to branch 115 Continuous Integration limited to net48 only though, so latest .NET Framework and Windows PowerShell. Delayed signing is removed from public ISHRemote project as described in #80 Using https://github.com/red-gate/XmlDoc2CmdletDoc as module (not as executable. All this, hat tip to Ivo!

* Closes #137 Better date time parsing fall backs, similar to branch 115

* #102 Extended ServicePointManager.SecurityProtocol with Tls13 and because branch release/v1 is a Windows PowerShell 5.1 and .NET Framework 4.8 only we can Close #102

* #102 Package version bump, especially PowerShellStandard from 5.1.0 to 5.1.1 and several ServiceModel-related packages from 4.7.0 to 4.9.0

* #102 CI Enable Windows PowerShell 5.1 based testing to ...sdlproducts.com

* #102 Added v1.0 human readable release notes

* #102 CI Differentiate with local and Github Actions based package/assembly versioning

* #146 Package improved XmlResolverUsingCatalog/XmlOASISCatalog classes aligning with 14SP4/14.0.4 code base

* #146 Package improved XmlResolverUsingCatalog/XmlOASISCatalog classes aligning with 14SP4/14.0.4 code base with corrected /// comment usage

Co-authored-by: ddemeyer <ddemeyer@rws.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant