Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add installaton of AdoptOpenJDK and JRE pre-requisite #48

Closed
beutepa opened this issue Oct 27, 2018 · 1 comment
Closed

Add installaton of AdoptOpenJDK and JRE pre-requisite #48

beutepa opened this issue Oct 27, 2018 · 1 comment
Assignees
@beutepa
Milestone
Version 1.7

Comments

@beutepa
Copy link
Collaborator

beutepa commented Oct 27, 2018 •
edited
Loading

Add installation of AdoptOpenJDK and JRE pre-requisite
beutepa added a commit that referenced this issue Oct 28, 2018
@beutepa
GH-48: SAdd installaton of AdoptOpenJDK pre-requisite
89b3b43
beutepa added a commit that referenced this issue Oct 28, 2018
@beutepa
GH-48: Add installaton of AdoptOpenJDK pre-requisite
a80a773
@ddemeyer
Copy link
Collaborator

I like this @beutepa ... technically however I think we should continue to distinguish JRE and JDK. The ZIP file you are adding contains JRE in the name but your variable is ISHServer:AdoptOpenJDK. So suggesting a ISHServer:AdoptOpenJRE next to the ISHServer:AdoptOpenJDK (and existing values JRE and JDK) as you can see in the platform dropdown on https://adoptopenjdk.net/installation.html

@ddemeyer ddemeyer mentioned this issue Oct 28, 2018
Closed
@beutepa beutepa changed the title Add installaton of AdoptOpenJDK pre-requisite Add installaton of AdoptOpenJDK and JRE pre-requisite Oct 30, 2018
beutepa added a commit to beutepa/ISHServer that referenced this issue Oct 30, 2018
@beutepa
RWSGH-48: Add installaton of AdoptOpenJDK and JRE pre-requisite
e4c9e04
beutepa added a commit to beutepa/ISHServer that referenced this issue Oct 30, 2018
@beutepa
RWSGH-48: Add installaton of AdoptOpenJDK and JRE pre-requisite
837c13e
beutepa added a commit that referenced this issue Oct 31, 2018
@beutepa
GH-48: Add installaton of AdoptOpenJDK and JRE pre-requisite (#49)
5b51726 
* GH-48: Add installaton of AdoptOpenJDK and JRE pre-requisite
beutepa added a commit to beutepa/ISHServer that referenced this issue Oct 31, 2018
@beutepa
RWSGH-48: Add installaton of AdoptOpenJDK and JRE pre-requisite
1c156cf
@beutepa beutepa closed this as completed Jan 11, 2019
@beutepa beutepa added this to the Version 1.7 milestone Jun 28, 2019
beutepa added a commit that referenced this issue Jun 28, 2019
@beutepa
GH-55 Merge changes to master (#63)
c973187 
* Beutepa patch issue 45 (#47)
    Get-ISHS3Object.ps1 does not return the file information when the object is already available locally
* GH-48: Add installaton of AdoptOpenJDK and JRE pre-requisite
* GH-50: Upgrade .NET Framework pre-requisite to 4.7.2 for the upcoming release of Tridion Docs 14.0.0
* GH-52: Add support for Windows Server 2019
* GH-55:  Review/Update readme, changelog, releasnotes,
@beutepa beutepa self-assigned this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutepa beutepa

Labels
None yet
Projects
None yet
Milestone
Version 1.7
Development

No branches or pull requests
2 participants
@beutepa @ddemeyer