Skip to content

Commit

Permalink
Merge pull request #58 from RWS/develop
Browse files Browse the repository at this point in the history
Merging all latest 2.2 updates to release branch
  • Loading branch information
avmgan authored Jan 31, 2024
2 parents 71692ea + bfb0ea4 commit 0c48bc1
Show file tree
Hide file tree
Showing 27 changed files with 10 additions and 142 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
SDL Digital Experience Accelerator CM-side framework
RWSDigital Experience Accelerator CM-side framework
===
Build status
------------
Expand Down Expand Up @@ -27,7 +27,7 @@ If you really have to modify the DXA Core TBBs, we kindly request you to submit

Support
---------------
At SDL we take your investment in Digital Experience very seriously, if you encounter any issues with the Digital Experience Accelerator, please use one of the following channels:
At RWS we take your investment in Digital Experience very seriously, if you encounter any issues with the Digital Experience Accelerator, please use one of the following channels:

- Report issues directly in [this repository](https://github.com/sdl/dxa-content-management/issues)
- Ask questions 24/7 on the SDL Tridion Community at https://tridion.stackexchange.com
Expand Down
6 changes: 3 additions & 3 deletions Sdl.Web.Tridion.Templates.R2/Data/DataModelBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ private object GetFieldValue(XmlElement xmlElement, int expandLinkDepth)
if (xmlElement.SelectSingleElement("xhtml:*") != null)
{
// XHTML field
return BuildRichTextModel(xmlElement);
return BuildRichTextModel(xmlElement, expandLinkDepth);
}

if (xmlElement.SelectSingleElement("*") != null)
Expand Down Expand Up @@ -292,7 +292,7 @@ private ViewModelData GetLinkFieldValue(IdentifiableObject linkedItem, int expan
return Pipeline.CreateKeywordModel(linkedKeyword, expandLinkDepth - 1);
}

protected RichTextData BuildRichTextModel(XmlElement xhtmlElement)
protected RichTextData BuildRichTextModel(XmlElement xhtmlElement, int expandLinkDepth = 0)
{
XmlDocument xmlDoc = xhtmlElement.OwnerDocument;
IList<EntityModelData> embeddedEntities = new List<EntityModelData>();
Expand All @@ -301,7 +301,7 @@ protected RichTextData BuildRichTextModel(XmlElement xhtmlElement)
Component linkedComponent = Pipeline.Session.GetObject(xlinkElement) as Component;
if (xlinkElement.LocalName == "img" || ShouldBeEmbedded(linkedComponent))
{
EntityModelData embeddedEntity = Pipeline.CreateEntityModel(linkedComponent, ct: null, expandLinkDepth: 0);
EntityModelData embeddedEntity = Pipeline.CreateEntityModel(linkedComponent, ct: null, expandLinkDepth: expandLinkDepth);

// Map each attribute to a metadata field

Expand Down
Binary file modified cms/content/sites9/all-publications/Binaries/2-70-2048.tbbasm
Binary file not shown.
Binary file modified cms/content/sites9/all-publications/Binaries/2-80-2048.tbbasm
Binary file not shown.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
&lt;TemplateInvocation&gt;
&lt;Template xlink:href="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Link%20Resolver.tbbcs" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:title="Link Resolver" /&gt;
&lt;/TemplateInvocation&gt;
&lt;TemplateInvocation&gt;
&lt;Template xlink:href="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Target%20Group%20Personalization.tbbcs" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:title="Target Group Personalization" /&gt;
&lt;/TemplateInvocation&gt;
&lt;TemplateInvocation&gt;
&lt;Template xlink:href="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Cleanup%20Template.tbbcs" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:title="Cleanup Template" /&gt;
&lt;/TemplateInvocation&gt;
Expand All @@ -36,6 +33,5 @@
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Convert%20Xml%20to%20Html.tbbcs" linkName="ExtractedReferences[1]" />
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Link%20Resolver.tbbcs" linkName="ExtractedReferences[2]" />
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Publish%20Binaries%20in%20Package.tbbcs" linkName="ExtractedReferences[3]" />
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Target%20Group%20Personalization.tbbcs" linkName="ExtractedReferences[4]" />
</Dependencies>
</PackageItem>

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
&lt;TemplateParameters&gt;
&lt;Parameters xmlns="http://www.sdl.com/web/schemas/dynamicpage"&gt;
&lt;expandLinkDepth xmlns="http://www.sdl.com/web/schemas/dynamicpage"&gt;2&lt;/expandLinkDepth&gt;
&lt;modelBuilderTypeNames&gt;DefaultModelBuilder;DefaultPageMetaModelBuilder;EclModelBuilder;ContextExpressionsModelBuilder&lt;/modelBuilderTypeNames&gt;
&lt;modelBuilderTypeNames&gt;DefaultModelBuilder;DefaultPageMetaModelBuilder;EclModelBuilder&lt;/modelBuilderTypeNames&gt;
&lt;/Parameters&gt;
&lt;/TemplateParameters&gt;
&lt;/TemplateInvocation&gt;
Expand Down
2 changes: 0 additions & 2 deletions cms/content/sites9/all-publications/index.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
<Item id="tcm:1-24-8" title="Link%20Resolver" extension="xsd" itemType="Schema" subtype="6" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-27-2048" title="Publish%20Binaries%20in%20Package" extension="tbbcs" itemType="TemplateBuildingBlock" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-26-8" title="Publish%20Binaries%20in%20Package" extension="xsd" itemType="Schema" subtype="6" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-28-2048" title="Target%20Group%20Personalization" extension="tbbcs" itemType="TemplateBuildingBlock" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-55-2048" title="Tridion%2EExtensions%2EContextExpressions%2ETemplates" extension="tbbasm" itemType="TemplateBuildingBlock" blueprintStatus="LocalItem" selected="false" exported="true" />
</Item>
<Item id="tcm:1-7-8192" title="Modified%20in%20the%20last%207%20days" itemType="VirtualFolder" blueprintStatus="LocalItem" selected="true" exported="true" />
<Item id="tcm:1-9-8" title="Default%20Multimedia%20Schema" extension="xsd" itemType="Schema" subtype="1" blueprintStatus="LocalItem" selected="false" exported="true" />
Expand Down
2 changes: 0 additions & 2 deletions cms/content/sites9/all-publications/mappings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -653,8 +653,6 @@
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Extract%20Components%20from%20Regions.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Link%20Resolver.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Publish%20Binaries%20in%20Package.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Target%20Group%20Personalization.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Tridion%2EExtensions%2EContextExpressions%2ETemplates.tbbasm" importContext="" importTitle="" />
<Mapping exportContext="/100%20Master/Building%20Blocks/Default%20Templates" exportTitle="Default%20Dreamweaver%20Page%20Design.dwt" importContext="" importTitle="" />
<Mapping exportContext="/100%20Master/Building%20Blocks/Framework/Developer/Templates/DXA%2ELegacy" exportTitle="Add%20inherited%20metadata%20to%20component.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/100%20Master/Building%20Blocks/Framework/Developer/Templates/DXA%2ELegacy" exportTitle="Add%20inherited%20metadata%20to%20page.tbbcs" importContext="" importTitle="" />
Expand Down
Binary file modified cms/content/sites9/framework-only/Binaries/2-70-2048.tbbasm
Binary file not shown.
Binary file modified cms/content/sites9/framework-only/Binaries/2-80-2048.tbbasm
Binary file not shown.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
&lt;TemplateInvocation&gt;
&lt;Template xlink:href="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Link%20Resolver.tbbcs" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:title="Link Resolver" /&gt;
&lt;/TemplateInvocation&gt;
&lt;TemplateInvocation&gt;
&lt;Template xlink:href="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Target%20Group%20Personalization.tbbcs" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:title="Target Group Personalization" /&gt;
&lt;/TemplateInvocation&gt;
&lt;TemplateInvocation&gt;
&lt;Template xlink:href="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Cleanup%20Template.tbbcs" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:title="Cleanup Template" /&gt;
&lt;/TemplateInvocation&gt;
Expand All @@ -36,6 +33,5 @@
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Convert%20Xml%20to%20Html.tbbcs" linkName="ExtractedReferences[1]" />
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Link%20Resolver.tbbcs" linkName="ExtractedReferences[2]" />
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Publish%20Binaries%20in%20Package.tbbcs" linkName="ExtractedReferences[3]" />
<Dependency dependencyType="TemplateLinkedItem" itemUrl="/webdav/000%20Empty/Building%20Blocks/Default%20Templates/Target%20Group%20Personalization.tbbcs" linkName="ExtractedReferences[4]" />
</Dependencies>
</PackageItem>

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
&lt;TemplateParameters&gt;
&lt;Parameters xmlns="http://www.sdl.com/web/schemas/dynamicpage"&gt;
&lt;expandLinkDepth xmlns="http://www.sdl.com/web/schemas/dynamicpage"&gt;2&lt;/expandLinkDepth&gt;
&lt;modelBuilderTypeNames&gt;DefaultModelBuilder;DefaultPageMetaModelBuilder;EclModelBuilder;ContextExpressionsModelBuilder&lt;/modelBuilderTypeNames&gt;
&lt;modelBuilderTypeNames&gt;DefaultModelBuilder;DefaultPageMetaModelBuilder;EclModelBuilder&lt;/modelBuilderTypeNames&gt;
&lt;/Parameters&gt;
&lt;/TemplateParameters&gt;
&lt;/TemplateInvocation&gt;
Expand Down
2 changes: 0 additions & 2 deletions cms/content/sites9/framework-only/index.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
<Item id="tcm:1-24-8" title="Link%20Resolver" extension="xsd" itemType="Schema" subtype="6" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-27-2048" title="Publish%20Binaries%20in%20Package" extension="tbbcs" itemType="TemplateBuildingBlock" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-26-8" title="Publish%20Binaries%20in%20Package" extension="xsd" itemType="Schema" subtype="6" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-28-2048" title="Target%20Group%20Personalization" extension="tbbcs" itemType="TemplateBuildingBlock" blueprintStatus="LocalItem" selected="false" exported="true" />
<Item id="tcm:1-55-2048" title="Tridion%2EExtensions%2EContextExpressions%2ETemplates" extension="tbbasm" itemType="TemplateBuildingBlock" blueprintStatus="LocalItem" selected="false" exported="true" />
</Item>
<Item id="tcm:1-9-8" title="Default%20Multimedia%20Schema" extension="xsd" itemType="Schema" subtype="1" blueprintStatus="LocalItem" selected="false" exported="true" />
</Item>
Expand Down
2 changes: 0 additions & 2 deletions cms/content/sites9/framework-only/mappings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Extract%20Components%20from%20Regions.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Link%20Resolver.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Publish%20Binaries%20in%20Package.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Target%20Group%20Personalization.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/000%20Empty/Building%20Blocks/Default%20Templates" exportTitle="Tridion%2EExtensions%2EContextExpressions%2ETemplates.tbbasm" importContext="" importTitle="" />
<Mapping exportContext="/100%20Master/Building%20Blocks/Default%20Templates" exportTitle="Default%20Dreamweaver%20Page%20Design.dwt" importContext="" importTitle="" />
<Mapping exportContext="/100%20Master/Building%20Blocks/Framework/Developer/Templates/DXA%2ELegacy" exportTitle="Add%20inherited%20metadata%20to%20component.tbbcs" importContext="" importTitle="" />
<Mapping exportContext="/100%20Master/Building%20Blocks/Framework/Developer/Templates/DXA%2ELegacy" exportTitle="Add%20inherited%20metadata%20to%20page.tbbcs" importContext="" importTitle="" />
Expand Down
Binary file modified cms/content/sites9/master-only/Binaries/2-70-2048.tbbasm
Binary file not shown.
Binary file modified cms/content/sites9/master-only/Binaries/2-80-2048.tbbasm
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
&lt;TemplateParameters&gt;
&lt;Parameters xmlns="http://www.sdl.com/web/schemas/dynamicpage"&gt;
&lt;expandLinkDepth xmlns="http://www.sdl.com/web/schemas/dynamicpage"&gt;2&lt;/expandLinkDepth&gt;
&lt;modelBuilderTypeNames&gt;DefaultModelBuilder;DefaultPageMetaModelBuilder;EclModelBuilder;ContextExpressionsModelBuilder&lt;/modelBuilderTypeNames&gt;
&lt;modelBuilderTypeNames&gt;DefaultModelBuilder;DefaultPageMetaModelBuilder;EclModelBuilder&lt;/modelBuilderTypeNames&gt;
&lt;/Parameters&gt;
&lt;/TemplateParameters&gt;
&lt;/TemplateInvocation&gt;
Expand Down

This file was deleted.

Loading

0 comments on commit 0c48bc1

Please sign in to comment.