Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move wheels upload into its own job #3454

Merged
merged 1 commit into from
Mar 10, 2023
Merged

ci: move wheels upload into its own job #3454

merged 1 commit into from
Mar 10, 2023

Conversation

nikaro
Copy link
Contributor

@nikaro nikaro commented Mar 10, 2023

Since #3448 Windows wheels upload takes more than 1h. Let's try to do one upload (on Ubuntu) for all platforms.

@nikaro nikaro marked this pull request as ready for review March 10, 2023 12:41
@nikaro
Copy link
Contributor Author

nikaro commented Mar 10, 2023

Copy/paste my comment from another PR of what could be an improvement:

Actually, GitHub runners come with AWS CLI installed so it should be even more straightforward to just use aws s3 sync ./wheelhouse s3://gensim-wheels (cf. https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html).

In the meantime, i pushed this PR, and it works and has the advantage also to provide the wheels as GitHub artifacts (see at the bottom of the workflow summary page). Replacing wheelhouse-uploader by aws s3 sync should be very simple, but i don't have an AWS playground to test it.

@mpenkov
Copy link
Collaborator

mpenkov commented Mar 10, 2023

OK, thanks for this. I'll merge and then see if anything further needs to be done.

@mpenkov mpenkov merged commit 3ab5371 into piskvorky:develop Mar 10, 2023
@nikaro nikaro deleted the upload-job branch March 10, 2023 13:49
@nikaro
Copy link
Contributor Author

nikaro commented Mar 10, 2023

There is definitely something strange with Windows(?) wheels i guess: https://github.com/RaRe-Technologies/gensim/actions/runs/4384850019/jobs/7677703653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants