This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Implement material browser window #287
Draft
nukeandbeans
wants to merge
56
commits into
RadicalCSG:master
Choose a base branch
from
nukeandbeans:material-browser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Adds material browser window * Moves preview materials to their own folder (allows simplified filtering in search) * Modified labels on default materials
…n thumbnail caching
also modified .gitignore to ignore a material package, this can be removed before this PR is merged.
finish implementing thumbnail caching.
should prevent cases where a thumbnail isnt cached because there is a duplicate file name in the project somewhere, but the material isnt actually a duplicate material.
this will be moved over to the actual window once i figure out how i want it laid out
need to figure out what to do with the tabs and fix a layout bug, then work out how to port over the IMGUI functionality
- optimized out any remaining per-frame allocations - removed caching system, this is handled by unity internally - added back window resizability, bringing with it ui that scales with the window - removed all UI Toolkit code - ported everything back to the main material browser window - removed all testing code - adjusted temporary texture brightness shown when a thumbnail is rendering - the last selected thumbnail is now highlighted
…visible, and added custom tooltips using a system similar to probuilder
- Removed custom tooltips and related dependencies. These are something that can be implemented later in a cleaner way. - UI tweaks, cleanup, and optimization. - Bump project version to 2020.2.f1
…nd add unity tooltips to tiles.
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Outdated
Show resolved
Hide resolved
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Outdated
Show resolved
Hide resolved
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Outdated
Show resolved
Hide resolved
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Outdated
Show resolved
Hide resolved
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Outdated
Show resolved
Hide resolved
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Outdated
Show resolved
Hide resolved
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Show resolved
Hide resolved
...ges/com.chisel.editor/Chisel/Editor/Editor/MaterialBrowser/ChiselMaterialBrowserUtilities.cs
Show resolved
Hide resolved
Rewrite tile filters: Made the code a lot easier to maintain, and much simpler to the same effect. Filters no longer require manual typing to add new folders/shaders/materials to ignore, which will allow implementing end-user defined filters. Remove surface presets: I removed surface presets for this current release target. I'll be looking into another way to do this, which may make things a bit easier to deal with. Modularize tiles: Made the tiles class more generic, which in the future will make adding additional asset types much easier.
…re things may have not been 100% clear, and added notes for things that arent immediately important
"packages/com.chisel.components/package resources/preview materials/", // 2, these are tool textures, so we are ignoring them | ||
"font material", // 3, ignore font materials | ||
"skybox/", // 4, ignore skybox shader | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also ignore everything in any "Editor Resources" directory
…her things that need attention, adjust some UI styling, update gitignore
* Adjust namespace + Add new test scene + Add new BrowserTab API (wip) - Remove dysfunctional test scenes
Hey @kerfuffles any news on this? |
This is still being worked on. I'm slowly working on this during my free time between work and other projects. I'm currently reworking the backend of it to be more flexible and extensible. |
Ok, Cool. Glad to know it is not dead :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #286 at a basic level and can possibly close #114 at a later time, but still needs a bunch of optimization.
Notes were left in the header of
MaterialBrowserWindow
Example without search (materials from Surfaces asset)
Example with search
Example with label filtering (and search)
Sidebar
The material browser has a sidebar with various properties and shortcuts, such as tag search from the selected material, selecting in the project, and applying to the currently selected face.
When the sidebar is collapsed, it makes the browser extremely compact, so it can be docked in a small area while using mini thumbnails.
TODO
Implement surface presets.Not going to implement this for current release target.Known issues