Added total statements metric to avoid overlaps with coremetrics #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the core metric STATEMENTS value is already set scoverage will not overwrite the value but the existing value will also not align with the covered statement values. Using a separated value solves this problem - Added totalStatements to the plugin metrics
RadoBuransky
added a commit
that referenced
this pull request
Oct 25, 2015
…overage Added total statements metric to avoid overlaps with coremetrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thats the 3rd in a series of 3 pull request I tried to separate functionality a bit.
this one is independent of the others
The statements core metric is sometimes already filled by other plugins (probably Java plugins?) and reading out the values in the Sensor has been deprecated. I think it would be best to use a new metric to avoid conflicts with other (e.g. class file based) plugins.
The Pull Request implements this.
ok thats it (-.
Best Michael