Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various build system fixes #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

emilazy
Copy link

@emilazy emilazy commented Jun 22, 2024

Hi there, I see you’re also a Nix user! Unfortunately some assumptions about Nixpkgs’s strange macOS OpenGL setup were baked into the code, so your project couldn’t be built on macOS without Nix, and a pull request I’m working on to clean them up in Nixpkgs broke the build there too. I’ve fixed those issues here, along with a couple others, and will be incorporating the patch into the Nixpkgs package for now.

By the way, it’d technically be better to use dependency('gl') instead, because Meson has special handling for this string. Unfortunately, because of the aforementioned Nixpkgs OpenGL weirdness, this produces a non‐functional build with the current stable Nixpkgs release. You might want to consider making that change after the current release is out of support, if you spend any time on this codebase in future.

@Radvendii
Copy link
Owner

Thank you so much for fixing this =)

Right now I am fixing cross-compilation to windows with the updated nixpkgs.

I don't have a Mac OS machine to check it on right now; Did you checked compilation both with- and without- nix, and that the game actually runs?

@Radvendii
Copy link
Owner

(i should really set up CI...)

@emilazy
Copy link
Author

emilazy commented Jul 11, 2024

Yep, I checked the Nix build and a “normal” one using Homebrew for dependencies on macOS, and the game starts up fine (although I can’t say I’m particularly good at 1‐dimensional Mario!). Can’t speak for other platforms, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants