Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tags and links hard to read in darkmode #809

Closed
2 tasks done
sytone opened this issue Feb 7, 2023 · 8 comments
Closed
2 tasks done

[Bug]: Tags and links hard to read in darkmode #809

sytone opened this issue Feb 7, 2023 · 8 comments
Assignees
Labels
Visual Visual problem of the application

Comments

@sytone
Copy link

sytone commented Feb 7, 2023

Contact Details

github@sytone.com

What happened?

When using a db view and using lookup or tags the font colour is hard to read against the background. I have only come back to folder db recently and do not remember this from before.

Tries Default and Minimal themes and have the same display issue.

I did find similar issues but they were closed as fixed and I confirmed I am on the recent version. So either this is separate or there is something wrong locally and I have disabled everything to go back to default with the same display issue showing.

image

image

Example config:
- { label: "Completed", backgroundColor: "hsl(107,79%,52%)"}
- { label: "Todo", backgroundColor: "hsl(79,73%,49%)"}
- { label: "In Progress", backgroundColor: "hsl(206,66%,56%)"}
- { label: "Discarded", backgroundColor: "hsl(300,2%,76%)"}
- { label: "Waiting", backgroundColor: "hsl(302,65%,53%)"}
- { label: "Archive", backgroundColor: "hsl(253,40%,68%)"}

What platform were you using?

Desktop

Version of the plugin

3.3.0

Relevant log output

No response

Are you using the latest version of the plugin in your Obsidian vault?

  • I have verified that I am on the latest version

Are you check if there is a similar issue?

  • I have verified that there are not similar issues
@sytone sytone added bug Something isn't working triage Issue not tagged yet. talking to the user labels Feb 7, 2023
@RafaelGB
Copy link
Owner

RafaelGB commented Feb 8, 2023

Hello @sytone ,
The color pf the text depends directly pf the used theme. To support all kind of configurations I was thinking about to add a new color property to the tags column to select the text color

@RafaelGB RafaelGB added Visual Visual problem of the application and removed bug Something isn't working triage Issue not tagged yet. talking to the user labels Feb 8, 2023
@RafaelGB RafaelGB moved this to 🥶 backlog in Obsidian database plugin Roadmap Feb 8, 2023
@GaboCapo
Copy link
Contributor

Here is a little Workaround with CSS Fix for that Issue, tested for the "Minimal" Theme.
just add a file e.g. cssfix.css in snippets Folder in your .obsidian Folder.
Reference:
https://help.obsidian.md/Extending+Obsidian/CSS+snippets

.markdown-preview-view.database-plugin__markdown-preview-view {
    color: #606060;
}

@RafaelGB RafaelGB moved this from 🥶 backlog to 👩‍💻👨‍💻 In progress in Obsidian database plugin Roadmap Feb 15, 2023
@RafaelGB RafaelGB moved this from 👩‍💻👨‍💻 In progress to 🏁👍 Ready for the next version in Obsidian database plugin Roadmap Feb 15, 2023
@RafaelGB
Copy link
Owner

Commit db3839f fixed =)

@cesarpereira904
Copy link

Hi @RafaelGB @GaboCapo

Another suggestion, because Relationlinks can have a background just like tags, I find the default hyperlinks do not fit most of the background colors I set:

Image

I would suggest for links to have same default text color:

Image

.markdown-preview-view.database-plugin__markdown-preview-view a:link{
color: #dadada !important;
text-decoration: none;
}

and to be able to distinguish a link from normal text to introduce a new symbol, just like this example:

Image

what do you think?

@RafaelGB
Copy link
Owner

Could be a good option, sure!

@RafaelGB
Copy link
Owner

Included with next version

.database-plugin__relation-container .database-plugin__relationship a:link {
  color: #dadada;
  text-decoration: none;
}

.database-plugin__relation-container .database-plugin__relationship a:hover {
  color: #a38484;
}

@cyb3rw0lf
Copy link

how to separate the color for normal text fields and fields with the background?
In dark theme if I choose a dark color it will be applied on both so either the text field or the ones with light background will be barely readable.

.markdown-preview-view.database-plugin__markdown-preview-view {
  color: #494949;
}

darkthemeissue

.markdown-preview-view.database-plugin__markdown-preview-view {
  color: #dadada;
}

darkthemeissuelight

@RafaelGB RafaelGB moved this from 🏁👍 Ready for the next version to <g-emoji fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/2705.png" alias="white_check_mark" class="g-emoji">✅</g-emoji> Done in Obsidian database plugin Roadmap Feb 26, 2023
@RafaelGB
Copy link
Owner

available with 3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Visual Visual problem of the application
Projects
Status: Done
Development

No branches or pull requests

5 participants