Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Non-use of native colour palette for label backgrounds causes odd-looking results #823

Closed
2 tasks done
robertandrews opened this issue Feb 16, 2023 · 2 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@robertandrews
Copy link

Contact Details

No response

What happened?

The way colours are implemented for tag and relation value backgrounds leaves it open to poor-looking results.

Here is the default colour when used in dark mode...

IMG_1140

This problem is multiplied infinitely because you use a full colour value picker.

You could condense the available colours down to a handful, each of which has a light mode and dark mode representation, like how, say, Notion does it.

PS. Use of background colours behind links to relation items, which is uncommon, may conflate the relation with tags, where the convention is more commonplace.

What platform were you using?

Mobile

Version of the plugin

3.3.1

Relevant log output

No response

Are you using the latest version of the plugin in your Obsidian vault?

  • I have verified that I am on the latest version

Are you check if there is a similar issue?

  • I have verified that there are not similar issues
@robertandrews robertandrews added bug Something isn't working triage Issue not tagged yet. talking to the user labels Feb 16, 2023
@RafaelGB
Copy link
Owner

will be fixed with this one #809

@RafaelGB RafaelGB added duplicate This issue or pull request already exists and removed triage Issue not tagged yet. talking to the user labels Feb 16, 2023
@robertandrews
Copy link
Author

Not specific to dark mode. See this picture of a relation. The text is unreadable.

IMG_1256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants