Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.$broadcast('$stateChangeSuccess #174

Closed
lenniebriscoe opened this issue Mar 4, 2016 · 1 comment
Closed

.$broadcast('$stateChangeSuccess #174

lenniebriscoe opened this issue Mar 4, 2016 · 1 comment

Comments

@lenniebriscoe
Copy link

The definition on ui-router shows the boadcast function as:
$rootScope.$on('$stateChangeSuccess',
function(event, toState, toParams, fromState, fromParams){ ... })

Many of the broadcasts from angular-permissions are overloading the fromState with options:
$rootScope.$broadcast('$stateChangeSuccess', toState, toParams, options);

A number of my functions are expecting fromState rather than options and this is causing errors. Something i'm doing wrong ?
@lenniebriscoe lenniebriscoe changed the title Confused between Permissions and Roles .$broadcast('$stateChangeSuccess Mar 4, 2016
@masterspambot
Copy link
Collaborator

Roger that. Will be solved in next version.

masterspambot added a commit that referenced this issue Mar 5, 2016
@masterspambot
Merge pull request #179 from Narzerus/feature/174
e201b4c 
fix: #174 - Removed options param from $stateChangeSuccess calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masterspambot @lenniebriscoe