Ensure parent permissions are evaluated only once #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Goal 1 marked #338.
The issue was, that if I had a state hierarchy like,
then, upon $state.go('root'), the
isLoggedIn
permission would evaluate twice, once for the parent and once for the child.This was due to UI-Router making the
data
property of states prototypically inherit from their parent. Thus if a child does not specify its ownpermissions
property, then it would use its parent property.This was easily fixed by making sure we would only use the permissions from a state that
hasOwnProperty('permissions')