Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMidiDevice merge into IDevice #254

Merged
merged 12 commits into from
Sep 23, 2023
Merged

IMidiDevice merge into IDevice #254

merged 12 commits into from
Sep 23, 2023

Conversation

Raffaello
Copy link
Owner

@Raffaello Raffaello commented Sep 22, 2023 •
edited
Loading

  • merge MidiDevice into device.
  • create a MIDDrv using a callback instead of a thread.
  • MT32 requires its own dedicated midi driver
  • try renderer a MIDI as it is, it won't be rendered due to the thread and delay to wait to send msg. need to be reviewed
  • device::Adlib decide what to do, it looks just redundant.
  • device::Adlib should have a method to play ADLFiles and MIDI?
  • Renderer ADL Files
  • Renderer MIDI Files

@Raffaello Raffaello self-assigned this Sep 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 39 Code Smells

0.0% 0.0% Coverage
0.1% 0.1% Duplication

@Raffaello Raffaello merged commit ca147cb into master Sep 23, 2023
6 of 8 checks passed
@Raffaello Raffaello deleted the improvemets2 branch September 23, 2023 15:35
@Raffaello Raffaello changed the title init IMidiDevice merge into IDevice Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Raffaello Raffaello

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Raffaello