Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives of openvpn process detection #85

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

mrtnmch
Copy link
Contributor

@mrtnmch mrtnmch commented Jan 3, 2020

On systems using NetworkManager, there's [nm-openvpn-auth] process
running. The present test for openvpn matches such a process and
fails to connect. Adding --exact fixes the problem as it matches
only "openvpn" processes (exactly).

On systems using NetworkManager, there's [nm-openvpn-auth] process
running. The present test for openvpn matches such a process and
fails to connect. Adding --exact fixes the problem as it matches
only "openvpn" processes (exactly).
@mrtnmch
Copy link
Contributor Author

mrtnmch commented Jan 3, 2020

Note this is an equivalent of the PR I submitted for the previous version (ProtonVPN/protonvpn-cli#192). I used --exact instead of -x for better readability.

@Rafficer
Copy link
Owner

Rafficer commented Jan 3, 2020

Thank you! This will make it into the next version, which will likely only be bug fixes :)

@Rafficer
Copy link
Owner

Rafficer commented Jan 7, 2020

I just noticed that --exact was added after -x. I think somewhere around v3.3 of procps.

All current distros definitely have that option (see https://pkgs.org/download/procps-ng), only distros without it I could find that might be used are RHEL/CentOS 6 and SLES 11. Since those are in no way consumer distros (and pretty much EOL anyway), I'd personally say f**k it and leave it as it is, using --exact. But I thought I'd mention it just to get other opinions as well.

So if someone thinks it should be -x for this reason, speak up 🙂

@kaplun
Copy link
Contributor

kaplun commented Jan 8, 2020

I think we can pretty much support modern distributions :-)

@Rafficer Rafficer merged commit 3d3ccbf into Rafficer:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants