new: typecheck more tests

Rafiot · Sep 11, 2024 · 42d25e1 · 42d25e1
1 parent 680004b
commit 42d25e1
Show file tree

Hide file tree

Showing 7 changed files with 73 additions and 59 deletions.
diff --git a/.mypy.ini b/.mypy.ini
@@ -18,14 +18,20 @@ ignore_errors = True
 [mypy-valkey._cache]
 ignore_errors = True
 
-
 [mypy-tests.*]
 ignore_errors = True
-
 [mypy-tests.test_commands]
 ignore_errors = False
 [mypy-tests.test_asyncio.test_commands]
 ignore_errors = False
+[mypy-tests.test_pipeline]
+ignore_errors = False
+[mypy-tests.test_asyncio.test_pipeline]
+ignore_errors = False
+[mypy-tests.test_pubsub]
+ignore_errors = False
+[mypy-tests.test_asyncio.test_pubsub]
+ignore_errors = False
 
 [mypy-benchmarks.*]
 ignore_errors = True

diff --git a/tests/test_asyncio/compat.py b/tests/test_asyncio/compat.py
@@ -1,6 +1,8 @@
 import asyncio
 from unittest import mock
 
+__all__ = ["mock", "aclosing", "create_task"]
+
 try:
     mock.AsyncMock
 except AttributeError:

diff --git a/tests/test_asyncio/test_pipeline.py b/tests/test_asyncio/test_pipeline.py
@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import pytest
 import valkey
 from tests.conftest import skip_if_server_version_lt
@@ -308,7 +310,7 @@ async def test_aclosing(self, r):
     async def test_transaction_callable(self, r):
         await r.set("a", 1)
         await r.set("b", 2)
-        has_run = []
+        has_run: list[str] = []
 
         async def my_transaction(pipe):
             a_value = await pipe.get("a")