Fix max-atomic-width target setting #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly rustc throws compiler errors since upstream commit
3be40b22c834 ("Fix AtomicPtr::from_mut align check: Avoid
generic arg in const expr.") [1].
They seem to be related to some discrepancies in the alignment
requirements for pointer types on AVR. While this should
probably be investigated at some point, for now let's set
`max-atomic-width` to 8 to make everything build again but
still retain at least some atomic types (those aren't actual
atomics but intrinsics that are lowered to critical sections
for atomic access).
[1]: rust-lang/rust@3be40b2
Signed-off-by: Rahix <rahix@rahix.de>
|
HI, FYI I opened this bug recently about this problem: rust-lang/rust#76833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly rustc throws compiler errors since upstream commit 3be40b22c834 ("Fix AtomicPtr::from_mut align check: Avoid generic arg in const expr.").
They seem to be related to some discrepancies in the alignment requirements for pointer types on AVR. While this should probably be investigated at some point, for now let's set
max-atomic-widthto 8 to make everything build again but still retain at least some atomic types (those aren't actual atomics but intrinsics that are lowered to critical sections for atomic access).