channel: Implement new escape sequence #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's follow systemd and use "CTRL-] three times within 1 second" as the universal escape sequence in tbot. There are a number of reasons for this: 1. The old `~.` would conflict with ssh sessions which means you need to escape the escape sequence (= `~~.`) when trying to exit a tbot interactive session inside an ssh session. 2. Any key-sequence made up of commonly used characters is bound to conflict _somewhere_. CTRL-] will most likely never show up in actual interaction and even less so as three consecutive presses. Channel.attach_interactive() will now also print out a message instructing about this escape sequence. This should make sure nobody will ever get stuck inside an interactive session again. The old "CTRL-D to exit" behavior can be re-activated for specific usecases by setting the `ctrld_exit` parameter. Signed-off-by: Harald Seiler <hws@denx.de>
The re-acquisition of the shell needs to deal with the system still being in the innermost "user shell". This can happen when the interactive session is exited by pressing the escape sequence. Signed-off-by: Harald Seiler <hws@denx.de>
Drop the exit hint as that is now printed by attach_interactive() already. Signed-off-by: Harald Seiler <hws@denx.de>
This one should still use CTRL-D to exit behavior so explicitly re-enable it here. Signed-off-by: Harald Seiler <hws@denx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's follow systemd and use "
CTRL-]three times within 1 second" as the universal escape sequence in tbot. There are a number of reasons for this:~.would conflict with ssh sessions which means you need to escape the escape sequence (=~~.) when trying to exit a tbot interactive session inside an ssh session.CTRL-]will most likely never show up in actual interaction and even less so as three consecutive presses.Channel.attach_interactive()will now also print out a message instructing about this escape sequence. This should make sure nobody will ever get stuck inside an interactive session again.The old "
CTRL-Dto exit" behavior can be re-activated for specific usecases using a new parameter.