Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an askfirst initializer for dealing with "askfirst" TTYs #98

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

Rahix
Copy link
Owner

@Rahix Rahix commented Aug 24, 2023

To use it, add board.AskfirstInitializer before board.LinuxBootLogin.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Patch coverage: 86.36% and project coverage change: -0.22% ⚠️

Comparison is base (0195fba) 55.73% compared to head (06b25cd) 55.51%.

❗ Current head 06b25cd differs from pull request most recent head b561037. Consider uploading reports for the commit b561037 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   55.73%   55.51%   -0.22%     
==========================================
  Files          53       53              
  Lines        3712     3914     +202     
==========================================
+ Hits         2069     2173     +104     
- Misses       1643     1741      +98     
Files Changed Coverage Δ
tbot/machine/board/linux.py 77.09% <85.71%> (-0.36%) ⬇️
tbot/machine/board/__init__.py 79.16% <100.00%> (+0.90%) ⬆️

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Rahix added 3 commits August 24, 2023 17:46
Add an initializer which catches the prompt of TTYs configured with
`askfirst`.  It then sends a newline to activate the console so a
following `LinuxBootLogin` can then take care of logging in.

Signed-off-by: Harald Seiler <hws@denx.de>
In the mocked board linux machine, also test the AskfirstInitializer
alongside LinuxBootLogin.

Signed-off-by: Harald Seiler <hws@denx.de>
Signed-off-by: Harald Seiler <hws@denx.de>
@Rahix Rahix merged commit b561037 into master Aug 24, 2023
@Rahix Rahix deleted the askfirst branch August 24, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants