Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix QUAT type registration after clang-format #562

Merged

Conversation

senselessDev
Copy link
Contributor

The types with a colon and QUAT did not work for me. I think the problem is that clang-format changed the originally intended VERTEX_SE3:QUAT to VERTEX_SE3 : QUAT. This is reverted by this PR and it should not occur in the future anymore due to the temporary deactivation of clang-format.

@senselessDev
Copy link
Contributor Author

Potentially also happened in

G2O_REGISTER_TYPE(ONLINE_VERTEX_SE3 : QUAT, OnlineVertexSE3);
G2O_REGISTER_TYPE(ONLINE_EDGE_SE3 : QUAT, OnlineEdgeSE3);

@RainerKuemmerle
Copy link
Owner

Thank you.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #562 (ba5d605) into master (4736df5) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   46.73%   46.73%           
=======================================
  Files         271      271           
  Lines       10775    10775           
=======================================
  Hits         5036     5036           
  Misses       5739     5739           
Impacted Files Coverage Δ
g2o/types/slam3d/types_slam3d.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4736df5...ba5d605. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants