Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymem relaxjson #831

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Pymem relaxjson #831

merged 4 commits into from
Aug 24, 2024

Conversation

RainerKuemmerle
Copy link
Owner

No description provided.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.72%. Comparing base (c0f51d9) to head (96e1819).
Report is 4 commits behind head on pymem.

Files Patch % Lines
g2o/core/io/io_wrapper_json.h 94.44% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            pymem     #831      +/-   ##
==========================================
+ Coverage   65.67%   65.72%   +0.05%     
==========================================
  Files         342      342              
  Lines       13383    13409      +26     
  Branches     1317     1319       +2     
==========================================
+ Hits         8789     8813      +24     
  Misses       4207     4207              
- Partials      387      389       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Store vertex / edge data and edge param_ids only if not empty. Reading
the JSON treads those elements as optional.

This reduces the data size a bit and focuses on required information.
@RainerKuemmerle RainerKuemmerle merged commit 046e114 into pymem Aug 24, 2024
7 checks passed
@RainerKuemmerle RainerKuemmerle deleted the pymem-relaxjson branch August 24, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant