Skip to content

Commit

Permalink
build: improve the format-cpp error message
Browse files Browse the repository at this point in the history
Since we run the formatter only on PRs that are targeting the master
branch, let's specify that.

Refs: nodejs#42681 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
RaisinTen committed Apr 17, 2022
1 parent 24adba6 commit d55e95a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
echo
echo 'ERROR: Please run:'
echo
echo ' CLANG_FORMAT_START="$(git merge-base HEAD <target-branch-name>)" make format-cpp'
echo " CLANG_FORMAT_START="$\(git merge-base HEAD ${GITHUB_BASE_REF}\)" make format-cpp"
echo
echo 'to format the commits in your branch.'
exit "$EXIT_CODE"
Expand Down

0 comments on commit d55e95a

Please sign in to comment.