Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track require() source locations and additional metadata #10

Merged

Conversation

RaisinTen
Copy link
Owner

@RaisinTen RaisinTen commented Nov 5, 2024

perfetto

- The `require()` traces will now have an `args` object which is
  formatted into a table in the <https://ui.perfetto.dev>> view.
- Metadata for other measurements can be passed using the
  <https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#detail>
  property and it would be set as the `args` object on the trace object.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Copy link

@shraddhaarora shraddhaarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@RaisinTen RaisinTen merged commit 2368914 into main Nov 6, 2024
9 checks passed
@RaisinTen RaisinTen deleted the track-require-source-locations-and-additional-metadata branch November 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants