Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap dependency installation in CI #9

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

RaisinTen
Copy link
Owner

The npx playwright install --with-deps command was producing this warning:

WARNING: It looks like you are running 'npx playwright install' without first
installing your project's dependencies.

so this change addresses that by running npm ci before running npx playwright install --with-deps.

Refs: https://github.com/RaisinTen/perftrace/actions/runs/10806970534/job/30191988723#step:4:7

The `npx playwright install --with-deps` command was producing this warning:

```
WARNING: It looks like you are running 'npx playwright install' without first
installing your project's dependencies.
```

so this change addresses that by running `npm ci` before running
`npx playwright install --with-deps`.

Refs: https://github.com/RaisinTen/perftrace/actions/runs/10806970534/job/30191988723#step:4:7
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen merged commit 5e563c4 into main Sep 16, 2024
9 checks passed
@RaisinTen RaisinTen deleted the swap-dependency-installation-in-ci branch September 16, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant