Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About us page made responsive #591

Merged
merged 4 commits into from
Feb 21, 2024
Merged

About us page made responsive #591

merged 4 commits into from
Feb 21, 2024

Conversation

AftabMankapure
Copy link
Contributor

@AftabMankapure AftabMankapure commented Feb 18, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #539

Description👨‍💻

About us page is made responsive.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

github-actions[bot]
github-actions bot reviewed Feb 18, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AftabMankapure, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@netlify Netlify
Copy link

netlify bot commented Feb 18, 2024 •
edited
Loading

✅ Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit d6e5083
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/65d630afd259520008d3d464
😎 Deploy Preview https://deploy-preview-591--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AftabMankapure
Copy link
Contributor Author

pls check this PR

@Rakesh9100
Copy link
Owner

Don't change the main UI, you have to make properly responsive for small screens without altering the UI of larger screens @AftabMankapure

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 18, 2024
@Rakesh9100 Rakesh9100 changed the title [Bug] About us page is not responsive #539 About us page made responsive Feb 18, 2024
@AftabMankapure
Copy link
Contributor Author

pls check now

@AftabMankapure
Copy link
Contributor Author

check this PR

@AftabMankapure
Copy link
Contributor Author

pls review the PR

@AftabMankapure
Copy link
Contributor Author

@Rakesh9100 any issue in PR

@Rakesh9100
Copy link
Owner

Merged 🎉 @AftabMankapure

@Rakesh9100 Rakesh9100 merged commit 924f075 into Rakesh9100:main Feb 21, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added enhancement ✨ New feature or request Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 JWOC JWOC 2k24 Open Source Program Completed 🥳 PR successfully merged and issue resolved on completion and removed question 🤔 Further information is requested enhancement ✨ New feature or request labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@AftabMankapure AftabMankapure

Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy IWOC2k24 (10 Points) ✨, JWOC2k24 (1 Point) 🎉, SWOC2k24 Level-1 (20 Points) 💫 JWOC JWOC 2k24 Open Source Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] About us page is not responsive
2 participants
@AftabMankapure @Rakesh9100