Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar elements readability fixed in mobile devices #582

Closed
wants to merge 6 commits into from
Closed

Navbar elements readability fixed in mobile devices #582

wants to merge 6 commits into from

Conversation

Abhishek-465
Copy link

Fixes Issue🛠️

#581

Closes #581

Description👨‍💻

I have adjusted the CSS and HTML files to make the content visible.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)

How this has been tested✅

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of image
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot (11)

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit d04a0c5
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/65cf77a5758dcc00083df3d7
😎 Deploy Preview https://deploy-preview-582--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Abhishek-465, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100
Copy link
Owner

image

Just keep your changes without making any indentation or other changes @Abhishek-465

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 12, 2024
@Abhishek-465
Copy link
Author

image

Just keep your changes without making any indentation or other changes @Abhishek-465

Okay then correcting the indentation.

Corrected the indentation of the part which i have added.
@Abhishek-465
Copy link
Author

@Rakesh9100 Kindly look the change

@Rakesh9100
Copy link
Owner

Pls fix style.css indentation as well @Abhishek-465

@Rakesh9100 Rakesh9100 changed the title FIXED THE READABILITY ISSUE ON MOBILE DEVICES Navbar elements readability fixed in mobile devices Feb 15, 2024
@Abhishek-465
Copy link
Author

@Rakesh9100 I cannot understand what is the point of the indentation changes which you are referring.The code is working fine, the indentation also looks normal. I think there shouldn't be any problem with this PR.

@Rakesh9100
Copy link
Owner

image

Code is working fine, but the changes in any PR should be done only of your work and not any other unnecessary changes!!

Example:

image

Don't reduce 2 spaces, keep indentation of 4 spaces only as per the project @Abhishek-465

@Abhishek-465
Copy link
Author

@Rakesh9100 I have corrected all the indentations.
Kindly check it.
Thank you.

@Rakesh9100
Copy link
Owner

  1. Background should appear to the full down of the screen.

  2. Use any background color instead of any image or it's URL.

  3. Make the hamburger appearance same in Contributor, FAQ and contact page as well @Abhishek-465

@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Navbar elements not readable in mobile devices
2 participants