Finish s/<|w>/<?wb>/ in doc (headings.rakutest)
#4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `<|w>` works in Rakudo, it isn't official Raku, and while I personally like it, there's a chance it will go away. Its semantics are the same as `<?wb>`, which _is_ official Raku, so I've switched to that. (See also 5c1a147.) I meant my prior related commit (which changed the regex doc page) to be a PR because I wasn't 100% sure about the `X<...>` stuff and regardless of that I felt it could still do with a quick check by someone else. But I clicked the wrong button. Otoh, once I'd done that I thought it would almost certainly work and be wanted, and if it didn't it wouldn't be a big deal and would be easy for me to spot it even if no one else does, and to fix it. But for _this_ change I'm making sure I do it as a PR. I still expect it to work, but it may not, and the consequence of that might be a waste of others' time, and even if it does it might not be wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
<|w>works in Rakudo, it isn't official Raku, and while I personally like it, there's a chance it will go away. Its semantics are the same as<?wb>, which is official Raku, so I've switched to that. (See also 5c1a147.)I meant my prior related commit (which changed the regex doc page) to be a PR because I wasn't 100% sure about the
X<...>stuff and regardless of that I felt it could still do with a quick check by someone else. But I clicked the wrong button. Otoh, once I'd done that I thought it would almost certainly work and be wanted, and if it didn't it wouldn't be a big deal and would be easy for me to spot it even if no one else does, and to fix it.But for this change I'm making sure I do it as a PR. I still expect it to work, but it may not, and the consequence of that might be a waste of others' time, and even if it does it might not be wanted.
The problem
Solution provided