Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for memory usage #197

Closed
AlexDaniel opened this issue Aug 5, 2017 · 1 comment
Closed

Add tests for memory usage #197

AlexDaniel opened this issue Aug 5, 2017 · 1 comment
Labels
whateverable Issues affecting the bot framework (and therefore all of the bots)

Comments

@AlexDaniel
Copy link
Member

Some things used to leak in the past, so it would be great to:

  • Print memory usage before and after tests
  • Test that the memory usage is reasonable (or, alternatively, that it didn't increase since the beginning)

See also: https://github.com/Skarsnik/p6-linux-proc-statm
@AlexDaniel AlexDaniel added the whateverable Issues affecting the bot framework (and therefore all of the bots) label Aug 5, 2017
MasterDuke17 added a commit to MasterDuke17/whateverable that referenced this issue Sep 20, 2017
@MasterDuke17
Add memory used to uptime command
c6aa350 
Also log the output of the uptime command at the end of a test run for
each bot.

Addresses part of Raku#197.
AlexDaniel added a commit that referenced this issue Sep 29, 2017
@AlexDaniel
I ♥ systemd
845db2e 
This commit resolves many long-standing problems:

* Issue #25 (RESTRICTED setting) is resolved. Bots are still not fully
  secure, but now they are more secure that they've even been given
  that RESTRICTED setting is entirely useless
* Issue #52 (predictable filenames) is no longer blocked
* Issue #55 (sandboxable) is probably no longer relevant
* Issue #118 (ramfs for /tmp) now needs an update
* Issue #144 (bots leaving stuff behind) is resolved because every bot
  has its own /tmp
* Issue #183 (source ip issue) possibly has a systemd solution for it
* Issue #197 is tackled a little bit also because now there's a memory
  limit for every bot (3G for now, we can probably make it smaller)
* Issue #238 (e.g. forkbombs) is basically resolved, but needs a bit more work
* Moreover, there's now a watchdog that makes sure that bots come back
  online if something bad happens

Not that all of this wasn't possible without systemd, it's just that
it is so much easier now. Feel free to hate me as much as you want.
@AlexDaniel
Copy link
Member Author

I think this can be closed. See this comment: #80 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whateverable Issues affecting the bot framework (and therefore all of the bots)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel