Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for github, gitlab, bitbucket, … links #66

Open
AlexDaniel opened this issue Nov 30, 2016 · 1 comment
Open

Support for github, gitlab, bitbucket, … links #66

AlexDaniel opened this issue Nov 30, 2016 · 1 comment
Labels
evalable Issues related to Evalable bot whateverable Issues affecting the bot framework (and therefore all of the bots)

Comments

@AlexDaniel
Copy link
Member

Although we already support any links as long as the mime type is right, Camelia supports normal github, gitlab and bitbucket gist (or snippet) links. If evalable is supposed to work similarly to camelia, then it should do that as well.
@AlexDaniel AlexDaniel added evalable Issues related to Evalable bot whateverable Issues affecting the bot framework (and therefore all of the bots) labels Nov 30, 2016
@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
@AlexDaniel AlexDaniel removed the testneeded Issue is generally resolved but tests were not written yet label Mar 12, 2017
@AlexDaniel AlexDaniel added the ANNOYINg A problem that is encountered frequently label Oct 7, 2017
AlexDaniel added a commit that referenced this issue Jun 2, 2018
@AlexDaniel
Support for multifile gists
11aa020 
Resolves a long-standing issue #36 (but no tests yet).

It works by saving all files in ‘sandbox/’, which is pretty much the
only writable path. As a bonus, you should be able to use all saved
files from other bots (note that all bots will now support multifile
gists, so being able to reuse the files is not strictly needed).

Also, this commit somewhat resolves an annoying issue #66 (support for
non-raw github links), but I think we'd need to add gitlab and
bitbucket in order to close it completely.

How does it figure out which file should be executed? There are some
heuristics in place, but generally it will prefer perl6 scripts over
anything else (either use .p6 extension or include a shebang). There's
no such problem when there's only one file.

Note that in order to use .pm6 files you'd also need to
write ｢use lib ‘sandbox/’｣.
@AlexDaniel AlexDaniel removed the ANNOYINg A problem that is encountered frequently label Jun 2, 2018
@AlexDaniel
Copy link
Member Author

Github gists are now supported, I think same has to be done for gitlab and bitbucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
evalable Issues related to Evalable bot whateverable Issues affecting the bot framework (and therefore all of the bots)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel