Skip to content

Commit

Permalink
Auto merge of #128465 - GrigorenkoPV:128200, r=estebank
Browse files Browse the repository at this point in the history
Some `const { }` asserts for #128200

The correctness of code in #128200 relies on an array being sorted (so that it can be used in binary search later), which is currently enforced with `// tidy-alphabetical` (and characters being written in `\u{XXXX}` form), as well as lack of duplicate entries with conflicting keys, which is not currently enforced.

This PR changes it to using a `const{ }` assertion (and also checks for duplicate entries). Sadly, we cannot use the recently-stabilized `is_sorted_by_key` here, because it is not const (but it would not allow us to check for uniqueness anyways). Instead, let's write a manual loop.

Alternative approach (perfect hash function): #128463

r? `@ghost`
  • Loading branch information
bors committed Aug 8, 2024
2 parents c64cb48 + 67e7de3 commit c4e5e12
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit c4e5e12

Please sign in to comment.