Skip to content

Commit

Permalink
Auto merge of #95317 - Jules-Bertholet:round_ties_to_even, r=pnkfelix…
Browse files Browse the repository at this point in the history
…,m-ou-se,scottmcm

Add `round_ties_even` to `f32` and `f64`

Tracking issue: #96710

Redux of #82273. See also #55107

Adds a new method, `round_ties_even`, to `f32` and `f64`, that rounds the float to the nearest integer , rounding halfway cases to the number with an even least significant bit. Uses the `roundeven` LLVM intrinsic to do this.

Of the five IEEE 754 rounding modes, this is the only one that doesn't already have a round-to-integer function exposed by Rust (others are `round`, `floor`, `ceil`, and `trunc`).  Ties-to-even is also the rounding mode used for int-to-float and float-to-float `as` casts, as well as float arithmentic operations. So not having an explicit rounding method for it seems like an oversight.

Bikeshed: this PR currently uses `round_ties_even` for the name of the method. But maybe `round_ties_to_even` is better, or `round_even`, or `round_to_even`?
  • Loading branch information
bors committed Mar 7, 2023
2 parents 86a9db9 + 19782d2 commit 87b3c72
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 87b3c72

Please sign in to comment.