Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .dfu files #1058

Merged
merged 6 commits into from
Sep 25, 2021
Merged

Generate .dfu files #1058

merged 6 commits into from
Sep 25, 2021

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Sep 24, 2021

Adding in dfu files that have the dfu suffix

Will drop bin files once these are known to work.

Fixes #1050

@Ralim Ralim changed the title Ralim/dfuse header Generate .dfu files Sep 24, 2021
@Ralim
Copy link
Owner Author

Ralim commented Sep 24, 2021

@tormodvolden
Can you give this a look over

@tormodvolden
Copy link

Debian/Ubuntu ships dfuse-pack but doesn't install it in the path (yet?), you can pick it from /usr/share/doc/dfu-util/examples/dfuse-pack.py.gz (and uncompress).

@tormodvolden
Copy link

On the other hand their current version is so old you're better off picking it from upstream like you did :) Did you pretty-format the script?

@Ralim
Copy link
Owner Author

Ralim commented Sep 24, 2021

Haha, honestly didnt dig much except to find it wasnt in path; shrugged and pulled it in. I did format it as habit though (by virtue of opening it once in vscode and hitting save as habit).
Also if its not in ubuntu main package feels a bit weird to have to extract it from an odd path, as thats going to confuse any non-ubuntu uses out there (like me) 😂

@tormodvolden
Copy link

I'll pick up the reformatting upstream, with your authorship, if that's fine with you.

I have a dfu-util 0.11 including dfuse-pack.py in my PPA, using the package source "deb http://ppa.launchpad.net/tormodvolden/ppa/ubuntu trusty main" (also works on focal) if that could be an alternative.

@Ralim
Copy link
Owner Author

Ralim commented Sep 24, 2021

Oh the reformatting is done by tooling so I don't really need credit tbqh.

Do you expect the PPA to be around for the long term 😂 (Well at least until ubuntu puts it as part of the main package?)

If so, happy to swap to it

@tormodvolden
Copy link

Yes, the PPA has been around for ages and touch wood it will.

@Ralim
Copy link
Owner Author

Ralim commented Sep 24, 2021

Eugh the PPA requires a chunk more work to load in as need to either pull in keys or install the ppa helper I believe (which increase image size and runtime of CI) 😢

@Ralim Ralim merged commit 714ef4b into master Sep 25, 2021
@Ralim Ralim deleted the ralim/dfuse-header branch September 25, 2021 01:10
@Ralim
Copy link
Owner Author

Ralim commented Sep 25, 2021

@tormodvolden
If there is a simple way to use the PPA without pulling in more dependencies I will change to it :)
But merging this for now as its better than before

@tormodvolden
Copy link

Instead of using the ppa helper, you can import the PPA key with this, probably without new dependencies:

sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 4B1E287796DD5C9A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please include a DFU suffix in firmware files for USB DFU
2 participants