tackling issue #1140

[discip]

Please refer to #1140 for more details.

Tested this on both TS80P & Pinecil.
Worked well for both of them!

[Ralim]

Looks good to me, just need to fix MHP30 building and I'm happy :)

I think you just need to ensure the declarations are masked to match the functions they control

[discip]

@Ralim
Good morning Sir,

I think you just need to ensure the declarations are masked to match the functions they control

Sorry, but I don't really get what is meant by that. 😵
please help 🥺
It would be very helpful, if you could provide an example. 😊

[discip]

And there is one more thing, which I am not able to solve myself:
If the settings are set, so that affected subentries are hidden, the 'scrollbar' is not updated right away, instead it is required to reenter the menu.

Please help.

thanks in advance

[Ralim]

So the issue looks to be you have put the functions to control I'd they are shown or not, inside the #ifdef so that it's not included for the MHP30, but it needs to be included for the menu.

So most likely you just need to move the functions out of being in the #ifdef

[Ralim]

Scrolling is currently only updated when you enter a menu .

[discip]

@Ralim
Should be good to go.
Maybe someone, who owns the MHP30, could test this.

Scrolling is currently only updated when you enter a menu .

Is it possible to change that?
If so, would this imply any downsides?

[Ralim]

Is it possible to change that?

Yeah it is possible

If so, would this imply any downsides?

Mostly just more compute time, since it requires re-calling all of the "show" functions for each menu items.
Certainly doable without too much effort.
To keep this PR small I would say its best to make an issue for fixing this.

Maybe someone, who owns the MHP30, could test this.
Tested it quickly on mine and it looks to work :)