Generic shellscripts #1144
Merged
Generic shellscripts #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't use anything bash-specific, so it can be /bin/sh
Doesn't use anything bash-specific, so it can be a /bin/sh script Added quotes to MDPATH variable, as recommended by shellcheck utility
Doesn't use anything bash-specific, so can be a /bin/sh script
Modified quoting/variables as recommended by shellcheck
Doesn't use anything bash-specific so it can be a /bin/sh script
Change to more generic /bin/sh script * added support for using on shells that don't have UID variable; uses UID if it's available and calls "id -u" when it's not * modified quoting as recommended by shellcheck * changed to not use "$?" to check for failure. Now uses "if ! (command); then (fail condition); fi" for when a command fails
|
Hi, Since you used shellcheck for this, can you add shellcheck to the ci actions to maintain these changes |
|
Sorry for the late reply. I've never used GitHub Actions before, so I'm not
sure how I would go about enabling that automated ci. But I did find
https://github.com/reviewdog/action-shellcheck which apparently is a ci
action to run shellcheck with reviewdog on every pull request.
…On Wed, Dec 29, 2021, 3:24 PM Ben V. Brown ***@***.***> wrote:
Merged #1144 <#1144> into master.
—
Reply to this email directly, view it on GitHub
<#1144 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQN7DTNYRAGIQUKUERUXLITUTKSTTANCNFSM5KZ4LQBQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies shell scripts to be use a more generic /bin/sh where possible with minor changes for portability and otherwise has small changes in variable quoting and such as recommended by the shellcheck utility.
The source/build.sh script has been left as a bash, as it uses a lot of array functionality that isn't present in POSIX.