Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash ts100 linux #1167

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Fix flash ts100 linux #1167

merged 2 commits into from
Jan 6, 2022

Conversation

ysard
Copy link
Contributor

@ysard ysard commented Jan 6, 2022

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
  • Bug fix: Fix the following errors due to forgotten brackets in a test.:
rmdir: impossible de de supprimer « /tmp/ts100 »: Device or resource busy
Flash result:
/tmp/ts100/ts100.rdy
rmdir: impossible de de supprimer « /tmp/ts100 »: Device or resource busy
  • Add a method to automatically check if the flash is done correctly or not.
    The user no longer has to read the list of files on the partition and deduce whether everything is ok or not.
  • Other information:
    Please note that error messages in the checking function are now colored for better and faster understanding (in my opinion);
    BUT, this requires to use bash instead of the legacy sh Bourne Shell. And this is partially against 48b9097.
    Why I suggest this: No systems have been using sh by default for a very long time, and users who have voluntarily changed this setting have surely migrated to much more complete shells (tsh, zsh, etc.) that support this functionality.
    Note that the script will run on sh shell but the colors codes will be printed instead of interpreted.
    Of course, I can revert this specific part on your request.

ysard added 2 commits January 6, 2022 04:57
* Add a clean method to check if the flash is done correctly or not.
* Note that this partially reverts 48b9097 due to the bash shell use instead of legacy sh shell
(this is for the use of colors in the check report)
@Ralim Ralim merged commit f85c62c into Ralim:master Jan 6, 2022
@Ralim Ralim added this to the 2.17 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants