HALL only on Pinecil #1205
Merged
HALL only on Pinecil #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ralim thanks in advance |
|
Take out the changes to the python code is the simplest, keeping that array the same size across builds is fine |
|
Am I getting this right, that it would suffice, if I only change |
|
Yeah, since we dont really care if the python emits that string into the firmware; we just wont show it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know, if it's only me, but I think this should be limited only to devices supporting this feature.
Otherwise this may cause confusion and unnecessary questions about why the hall sensor is turned off (and how to turn it on) on certain irons (all current ones except for the Pinecil).
I've tested this on my TS80P and the Pinecil. It worked for both!
However CI spits out an formatting error. 🤷♂️ (I could not figure out what's wrong!)