Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese and Japanese translations #1445

Merged
merged 6 commits into from
Nov 6, 2022

Conversation

alvinhochun
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Translation update

  • Other information:

  • Fixed the English menu text used in the Japanese translation -- they have to use the two-line syntax same as English to be displayed properly.

  • The Japanese translation update was done with the help of Google translate, but I didn't dare to do this for the "Calibrate CJC" menu text. Best for this to be checked/updated by a Japanese speaker. CC @yuk7 @i4M1k0SU @skishida

  • @contactalexliu might want to check the Simplified Chinese translation...

  • @Ralim I have to revert Always use compressed data even for single languages #1430. Apparently it now takes too much RAM to extract the ZH_CN translation for the MHP30...

@Ralim
Copy link
Owner

Ralim commented Oct 26, 2022

Eugh running out of ram now.

Need to have some thoughts about this, the ZH_CN is pushing us on ram and flash depending on what state its in at one point in time.

@alvinhochun
Copy link
Contributor Author

Perhaps we may finally need to optimize it to store CJK glyphs as 12x12 bitmaps instead of padding them to 12x16... I don't have the time to implement this though...

@Ralim
Copy link
Owner

Ralim commented Oct 26, 2022

Yeah that's probably the best idea. Ill have a poke this weekend and see if I make any progress

@discip
Copy link
Collaborator

discip commented Oct 27, 2022

  • Fixed the English menu text used in the Japanese translation -- they have to use the two-line syntax same as English to be displayed properly.

Sorry I was not aware of that.

@discip
Copy link
Collaborator

discip commented Nov 1, 2022

@Ralim

and see if I make any progress

Did you make any progress? 😃

@Ralim Ralim merged commit f11f550 into Ralim:dev Nov 6, 2022
@Ralim
Copy link
Owner

Ralim commented Nov 6, 2022

So for now I'm merging this and happy to take the revert. Variable fonts and other optimisations need more work than I think I'll have time for, for now.

@discip
Copy link
Collaborator

discip commented Feb 2, 2023

@Ralim

Variable fonts and other optimisations need more work ...

Hasn't that already been implemented by revising the language handling?

Iirc it started with:
97651f0

and was completed with:
f9ce1ef

@Ralim
Copy link
Owner

Ralim commented Feb 2, 2023

It certainly had some more work but it's not optimal entirely yet.

Should still look into variable width font handling and possibly overhaul the some more of it. But it is a little better in my testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants