Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gui files #1478

Merged
merged 35 commits into from
Nov 26, 2022
Merged

Refactor gui files #1478

merged 35 commits into from
Nov 26, 2022

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Nov 23, 2022

This is purely a code cleanup change; splitting up GUI thread to make edits and reviews easier.

@discip
Copy link
Collaborator

discip commented Nov 24, 2022

@Ralim
I know it is not the right place.
But please help me at finding out which part I need to swap, to make the TS80P show the right temperature again.

Last time you told me a sign for damage (after having fed 20V instead of 12V into my device) would be a temperature drift.

I left the TS80P sit on the desk to let it acclimate before calibration. But even after some time, the difference displayed in the debug menu was ~6°C [Tip C 20 and Han C 26.0].

@Ralim
Copy link
Owner Author

Ralim commented Nov 24, 2022

Best would be to open a discussion for this; if you can. (I suspect it may be a long chat)
But TL;DR would be to figure out which is wrong (raw tip reading OR handle temp).
If its the handle temp its concerning as that circuit should just be a resistor and an NTC resistor
More likely its the raw tip and the biggest suspect is the op-amp that measures the tip temperature

@discip
Copy link
Collaborator

discip commented Nov 24, 2022

One thing I've wanted to know for some time is:

In what unit is this difference measured (< 10):

if (!isTipDisconnected() && (TipThermoModel::getTipInC() - getHandleTemperature(0) / 10) < 10) {

That should be in °C, right?

I am asking, because the calibration is not performed even though the difference is not close to 10°C.

Or should we check against the absolute value of the observed difference?

@Ralim
Copy link
Owner Author

Ralim commented Nov 24, 2022

Ah we probably should abs() that; getHandleTemp is in X10C (so the /10 to make it into C)

@discip
Copy link
Collaborator

discip commented Nov 24, 2022

Created a PR already. 😁

@Ralim Ralim marked this pull request as ready for review November 25, 2022 10:33
@Ralim Ralim merged commit 628b8fe into dev Nov 26, 2022
@Ralim Ralim deleted the refactor-gui-files branch November 26, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants