-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gui files #1478
Refactor gui files #1478
Conversation
@Ralim Last time you told me a sign for damage (after having fed 20V instead of 12V into my device) would be a temperature drift. I left the |
Best would be to open a discussion for this; if you can. (I suspect it may be a long chat) |
One thing I've wanted to know for some time is: In what unit is this difference measured ( IronOS/source/Core/Threads/GUIThread.cpp Line 101 in 30f1840
That should be in °C , right?
I am asking, because the calibration is not performed even though the difference is not close to 10°C. Or should we check against the absolute value of the observed difference? |
Ah we probably should abs() that; getHandleTemp is in X10C (so the /10 to make it into C) |
Created a PR already. 😁 |
This is purely a code cleanup change; splitting up GUI thread to make edits and reviews easier.