-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration.h #1625
Update configuration.h #1625
Conversation
@Ralim I should have looked for the settings in the config files of all the other devices before merging, as they also say 60°F instead of 50°F! I'm sorry for rushing. Should we revert this PR or should we change all other corresponding configs as well? |
10°C does not equal 60°F (conversion math not right in original code maybe) (10°C × 9/5) + 32 = 50°F |
Yes, I got that, but I suppose there is more to it than just converting one unit into the other, since all the other conversions don't match either: IronOS/source/Core/BSP/Pinecilv2/configuration.h Lines 132 to 137 in 0a4560e
|
i saw that too, figured Ralim was just rounding up the MAX temp on F to make it cleaner looking at 850 F instead of 842F. so I left that alone. but for 60F or 50F there is no reason for rounding since it's a whole number. |
@Ralim Please let me know if this should be reverted, or if we should adapt all the other configs as well. |
Still ongoing, just checking in here and there 😊 I'll be back next week. I would just update all the rest to match. |
Oh, sorry to interrupt! Enjoy your free time and relax. Have a good time! 😃 |
fixes tickert #1624
typo bug fix, 10C = 50F
Current code has 10C and 60F as minimum temperatures; they are not equivalant.
(10°C × 9/5) + 32 = 50°F