Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration.h #1625

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Update configuration.h #1625

merged 3 commits into from
Mar 14, 2023

Conversation

River-Mochi
Copy link
Contributor

fixes tickert #1624

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?

typo bug fix, 10C = 50F
Current code has 10C and 60F as minimum temperatures; they are not equivalant.
(10°C × 9/5) + 32 = 50°F

@discip
Copy link
Collaborator

discip commented Mar 14, 2023

@Ralim
I hope I did not do something I am going to regret. 🤦🏻

I should have looked for the settings in the config files of all the other devices before merging, as they also say 60°F instead of 50°F!

I'm sorry for rushing.

Should we revert this PR or should we change all other corresponding configs as well?

@River-Mochi
Copy link
Contributor Author

10°C does not equal 60°F (conversion math not right in original code maybe)

(10°C × 9/5) + 32 = 50°F

@discip
Copy link
Collaborator

discip commented Mar 14, 2023

Yes, I got that, but I suppose there is more to it than just converting one unit into the other, since all the other conversions don't match either:

#define MAX_TEMP_C 450 // Max soldering temp selectable °C
#define MAX_TEMP_F 850 // Max soldering temp selectable °F
#define MIN_TEMP_C 10 // Min soldering temp selectable °C
#define MIN_TEMP_F 50 // Min soldering temp selectable °F
#define MIN_BOOST_TEMP_C 250 // The min settable temp for boost mode °C
#define MIN_BOOST_TEMP_F 480 // The min settable temp for boost mode °F

450°C => 842°F
250°C => 482°F

@River-Mochi
Copy link
Contributor Author

i saw that too, figured Ralim was just rounding up the MAX temp on F to make it cleaner looking at 850 F instead of 842F. so I left that alone.

but for 60F or 50F there is no reason for rounding since it's a whole number.
but we shall see what is behind this soon.

@discip
Copy link
Collaborator

discip commented Mar 16, 2023

@Ralim
Is your vacation over?
If so, nice to have you back!
I hope you had time to relax.

Please let me know if this should be reverted, or if we should adapt all the other configs as well.
Just a reminder. 😊

@Ralim
Copy link
Owner

Ralim commented Mar 16, 2023

Still ongoing, just checking in here and there 😊 I'll be back next week.

I would just update all the rest to match.

@discip
Copy link
Collaborator

discip commented Mar 16, 2023

Oh, sorry to interrupt!
I didn't mean to do that.

Enjoy your free time and relax.

Have a good time! 😃

@discip discip mentioned this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants