metadata.py: update tagging considering github CI builds #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Make commit SHA ID for JSON files equal to the latest commit if it's pull-request.
What is the current behavior?
JSON files have commit ID which is not valid to the project tree in case of github CI builds during pull-requests.
What is the new behavior (if this is a feature change)?
Put proper valid commit ID into JSON files on github CI builds.
Other information:
Since now a proper SHA ID can be obtained during github CI builds using changes in
push.yml, utilize this for proper JSON tagging.