Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake World::modify impl #20

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fake World::modify impl #20

wants to merge 1 commit into from

Conversation

Ralith
Copy link
Owner

@Ralith Ralith commented Dec 22, 2019

Proof-of-concept for #19. Currently blocked by an ICE in the doctest:

error: internal compiler error: src/librustc/traits/codegen/mod.rs:55: Encountered error `OutputTypeParameterMismatch(Binder(<[closure@src/world.rs:10:5: 10:26] as std::ops::FnMut<(hecs::Entity, <hecs::query::FetchRead<bool> as hecs::Fetch<'_>>::Item)>>), Binder(<[closure@src/world.rs:10:5: 10:26] as std::ops::FnMut<(hecs::Entity, &bool)>>), Sorts(ExpectedFound { expected: &bool, found: <hecs::query::FetchRead<bool> as hecs::Fetch<'_>>::Item }))` selecting `Binder(<[closure@src/world.rs:10:5: 10:26] as std::ops::FnMut<(hecs::Entity, &bool)>>)` during codegen

@Astralchroma
Copy link

The internal compiler error seems to be resolved now, couldn't this potentially be revisited now?

@Ralith
Copy link
Owner Author

Ralith commented Dec 6, 2023

Probably! I forget if there was a realistic plan to make this work any better than using a command buffer, though. It's a pretty un-ergonomic API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants