Refactor VolSync Replication Code for Consistent Final Sync Preparation #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenamarMk
pushed a commit
to BenamarMk/ramen
that referenced
this pull request
May 14, 2024
Refactor final sync preparation and execution for PVCs targeted for VolSync replication, aligning code and behavior with VolRep. PR link: RamenDR#1395 Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
BenamarMk
force-pushed
the
volsync-finalsync-refactor
branch
from
b977797
to
55cd381
Compare
ELENAGER
reviewed
May 17, 2024
| @@ -474,7 +483,7 @@ func (v *VSHandler) createOrUpdateRS(rsSpec ramendrv1alpha1.VolSyncReplicationSo | |||
| ReplicationSourceVolumeOptions: volsyncv1alpha1.ReplicationSourceVolumeOptions{ | |||
| // Always using CopyMethod of snapshot for now - could use 'Clone' CopyMethod for specific | |||
There was a problem hiding this comment.
Comment is outdated - now it is not always snapshot - for final sync it is direct.
BenamarMk
pushed a commit
to BenamarMk/ramen
that referenced
this pull request
May 20, 2024
Refactor final sync preparation and execution for PVCs targeted for VolSync replication, aligning code and behavior with VolRep. PR link: RamenDR#1395 Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
BenamarMk
force-pushed
the
volsync-finalsync-refactor
branch
from
55cd381
to
8c783c4
Compare
BenamarMk
pushed a commit
to BenamarMk/ramen
that referenced
this pull request
May 20, 2024
Refactor final sync preparation and execution for PVCs targeted for VolSync replication, aligning code and behavior with VolRep. PR link: RamenDR#1395 Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
BenamarMk
force-pushed
the
volsync-finalsync-refactor
branch
from
8c783c4
to
74ac65f
Compare
Refactor final sync preparation and execution for PVCs targeted for VolSync replication, aligning code and behavior with VolRep. PR link: RamenDR#1395 Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
BenamarMk
force-pushed
the
volsync-finalsync-refactor
branch
from
74ac65f
to
bac34c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring the preparation and execution of final sync for PVCs targeted for VolSync replication. The main goal is to align the VolSync-related code and behavior with that of VolRep, ensuring logical consistency across the two processes.
In this PR, the following changes were made:
Eliminated the intermediate step of preparing for and executing final sync routines.
Redesigned the ownership handling of application PVCs during VRG transitions from primary to secondary (for relocation only).
Previously, application PVCs were owned by the VRG when in the primary state. This PR adjusts the ownership mechanism when switching from Primary to Secondary as follows:
After final sync is complete, Ramen cleans up the temporary PVC, leaving the PV in the Released status.
During the setup of the ReplicationDestination (when becoming Secondary), Ramen creates the application PVC, and the VRG assumes ownership. This ownership adjustment ensures that if the VRG is deleted, the application PVC is properly garbage collected.
TODO:
Addresses this comment: #558 (comment)