Add design doc elaborating how classes would be matched across peers #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
ShyamsundarR
commented
Jul 2, 2024
|
|
||
| ### DRPC reconciler changes to update VRG spec | ||
|
|
||
| Based on the DRPolicy used by the DRPC, VRGs created will carry a supported |
There was a problem hiding this comment.
We may potentially need spec.peerClasses than separate them out into sync|async.
BenamarMk
reviewed
Aug 6, 2024
|
|
||
| - Workload deployed PVC should contain the SC to use, or if default SC is the | ||
| choice then both ManagedClusters should contain the same SC as the default | ||
| - Typically as default SC can be changed at any time, it is advisable that |
There was a problem hiding this comment.
I believe the default storage class should be prohibited in DR for the same reason you mentioned. One day it works, and the next day, DR fails.
|
|
||
| Given the above we need to solve the following problems for Ramen | ||
|
|
||
| - Determining which PVCs can be reliably protected in a Sync or Async manner |
There was a problem hiding this comment.
Why do we need to solve it for the Sync case?
I think you addressed in the second half of this document that it is a better way to determine whether protection is for metro or regional.
| - Name: `SClass1` | ||
| - `ramendr.openshift.io/storageID: c1SID1` | ||
| - Name: `SClass2` | ||
| - `ramendr.openshift.io/storageID: c1SID2` |
There was a problem hiding this comment.
You mean c2SID1? Just so that line 163 is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.