Add distribution to drenv metadata #1416
Conversation
|
Looks quite useful. What about documenting this env variable. |
Right, need to document it. |
These tiny envs are useful for development of tools. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Document the environment name and ramen info. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
This can be used to do the right thing for ocp or k8s clusters in tests or tools. Signed-off-by: Nir Soffer <nsoffer@redhat.com>
| @@ -481,6 +481,17 @@ $ drenv delete envs/example.yaml | |||
|
|
|||
| ### The environment file format | |||
|
|
|||
| - `name`: environment name, used for logging | |||
|
|
|||
| - `ramen`: ramen metadata | |||
There was a problem hiding this comment.
ramen metadata looked like its a key to ramen but its not, may be add the text on line 485, just a nit.
There was a problem hiding this comment.
This is just like - templates and profiles - see line 493 and 534.
Can you suggest clear way to make it more clear?
Maybe have no text will be more clear?
There was a problem hiding this comment.
yes, probably having no text makes it more clear.
There was a problem hiding this comment.
Maybe we need to switch to CRD format so we have a format way to describe eveything, and also be able to use kustomize with environment files?
|
my observations are just nits, but on the whole. this looks good to me. |
This can be used to do the right thing for ocp or k8s clusters in tests or tools using environment files.